Fix unparseable string representation of CallableTypeParameterNode

ondrejmirtes · ondrejmirtes · commit f373259f520e · 2023-04-17T15:13:45.000+02:00
diff --git a/src/Ast/Type/CallableTypeParameterNode.php b/src/Ast/Type/CallableTypeParameterNode.php
@@ -41,8 +41,8 @@ public function __toString(): string
 		$type = "{$this->type} ";
 		$isReference = $this->isReference ? '&' : '';
 		$isVariadic = $this->isVariadic ? '...' : '';
-		$default = $this->isOptional ? ' = default' : '';
-		return trim("{$type}{$isReference}{$isVariadic}{$this->parameterName}") . $default;
+		$isOptional = $this->isOptional ? '=' : '';
+		return trim("{$type}{$isReference}{$isVariadic}{$this->parameterName}") . $isOptional;
 	}
 
 }
diff --git a/tests/PHPStan/Ast/ToString/TypeToStringTest.php b/tests/PHPStan/Ast/ToString/TypeToStringTest.php
@@ -102,7 +102,7 @@ public static function provideCallableCases(): Generator
 				], new IdentifierTypeNode('void')),
 			],
 			[
-				'callable(int = default, int $foo = default): void',
+				'callable(int=, int $foo=): void',
 				new CallableTypeNode(new IdentifierTypeNode('callable'), [
 					new CallableTypeParameterNode(new IdentifierTypeNode('int'), false, false, '', true),
 					new CallableTypeParameterNode(new IdentifierTypeNode('int'), false, false, '$foo', true),

Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,8 @@ public function __toString(): string`
`41`	`41`	`$type = "{$this->type} ";`
`42`	`42`	`$isReference = $this->isReference ? '&' : '';`
`43`	`43`	`$isVariadic = $this->isVariadic ? '...' : '';`
`44`		`- $default = $this->isOptional ? ' = default' : '';`
`45`		`- return trim("{$type}{$isReference}{$isVariadic}{$this->parameterName}") . $default;`
	`44`	`+ $isOptional = $this->isOptional ? '=' : '';`
	`45`	`+ return trim("{$type}{$isReference}{$isVariadic}{$this->parameterName}") . $isOptional;`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ public static function provideCallableCases(): Generator`
`102`	`102`	`], new IdentifierTypeNode('void')),`
`103`	`103`	`],`
`104`	`104`	`[`
`105`		`- 'callable(int = default, int $foo = default): void',`
	`105`	`+ 'callable(int=, int $foo=): void',`
`106`	`106`	`new CallableTypeNode(new IdentifierTypeNode('callable'), [`
`107`	`107`	`new CallableTypeParameterNode(new IdentifierTypeNode('int'), false, false, '', true),`
`108`	`108`	`new CallableTypeParameterNode(new IdentifierTypeNode('int'), false, false, '$foo', true),`