Refactoring - extract isNoopExpr

Author: ondrejmirtes

src/Rules/DeadCode/NoopRule.php

@@ -45,18 +45,7 @@ public function processNode(Node $node, Scope $scope): array
 					->build(),
 			];
 		}
-		if (
-			!$expr instanceof Node\Expr\Variable
-			&& !$expr instanceof Node\Expr\PropertyFetch
-			&& !$expr instanceof Node\Expr\StaticPropertyFetch
-			&& !$expr instanceof Node\Expr\NullsafePropertyFetch
-			&& !$expr instanceof Node\Expr\ArrayDimFetch
-			&& !$expr instanceof Node\Scalar
-			&& !$expr instanceof Node\Expr\Isset_
-			&& !$expr instanceof Node\Expr\Empty_
-			&& !$expr instanceof Node\Expr\ConstFetch
-			&& !$expr instanceof Node\Expr\ClassConstFetch
-		) {
+		if (!$this->isNoopExpr($expr)) {
 			return [];
 		}
 
@@ -74,4 +63,18 @@ public function processNode(Node $node, Scope $scope): array
 		];
 	}
 
+	public function isNoopExpr(Node\Expr $expr): bool
+	{
+		return $expr instanceof Node\Expr\Variable
+			|| $expr instanceof Node\Expr\PropertyFetch
+			|| $expr instanceof Node\Expr\StaticPropertyFetch
+			|| $expr instanceof Node\Expr\NullsafePropertyFetch
+			|| $expr instanceof Node\Expr\ArrayDimFetch
+			|| $expr instanceof Node\Scalar
+			|| $expr instanceof Node\Expr\Isset_
+			|| $expr instanceof Node\Expr\Empty_
+			|| $expr instanceof Node\Expr\ConstFetch
+			|| $expr instanceof Node\Expr\ClassConstFetch;
+	}
+
 }