Fix TemplateTypeMap::isEmpty()

phpstan · Aug 16, 2021 · f7250db · f7250db
1 parent cee6f68
commit f7250db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/Type/Generic/TemplateTypeMap.php b/src/Type/Generic/TemplateTypeMap.php
@@ -65,12 +65,12 @@ public static function createEmpty(): self
 
 	public function isEmpty(): bool
 	{
-		return count($this->types) === 0;
+		return $this->count() === 0;
 	}
 
 	public function count(): int
 	{
-		return count($this->types);
+		return count($this->types + $this->lowerBoundTypes);
 	}
 
 	/** @return array<string,\PHPStan\Type\Type> */

diff --git a/tests/PHPStan/Type/Generic/TemplateTypeMapTest.php b/tests/PHPStan/Type/Generic/TemplateTypeMapTest.php
@@ -15,6 +15,11 @@ public function dataUnionWithLowerBoundTypes(): iterable
 			'T' => new ObjectType(\Exception::class),
 		]))->convertToLowerBoundTypes();
 
+		yield [
+			$map,
+			\Exception::class,
+		];
+
 		yield [
 			$map->union(new TemplateTypeMap([
 				'T' => new ObjectType(\InvalidArgumentException::class),
@@ -51,6 +56,7 @@ public function dataUnionWithLowerBoundTypes(): iterable
 	/** @dataProvider dataUnionWithLowerBoundTypes */
 	public function testUnionWithLowerBoundTypes(TemplateTypeMap $map, string $expectedTDescription): void
 	{
+		$this->assertFalse($map->isEmpty());
 		$t = $map->getType('T');
 		$this->assertNotNull($t);
 		$this->assertSame($expectedTDescription, $t->describe(VerbosityLevel::precise()));