Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update composer itself to latest snapshot #1331

Merged
merged 1 commit into from
Aug 5, 2018

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Aug 4, 2018

This PR

  • updates composer itself to latest snapshot

Related to ergebnis/composer-normalize#68 (comment).
Follows composer/composer#7516 (comment).

πŸ’β€β™‚οΈ This is a temporary patch until 1.7.1 is released.

@ondrejmirtes
Copy link
Member

Hi, I'm not a fan of including Composer itself here, it adds unnecessary baggage to the Git repo, could we persuade Travis and AppVeyor to install older version instead?

@localheinz
Copy link
Contributor Author

@ondrejmirtes

Absolutely, give me a moment!

@localheinz localheinz force-pushed the fix/composer-normalize branch 3 times, most recently from 733d726 to ff45b63 Compare August 4, 2018 13:51
@localheinz localheinz changed the title Fix: Check in composer.phar Fix: Install composer.phar@1.6.5 Aug 4, 2018
@localheinz localheinz changed the title Fix: Install composer.phar@1.6.5 [WIP] Fix: Install composer.phar@1.6.5 Aug 4, 2018
build.xml Outdated
@@ -12,9 +13,21 @@
phpstan
"/>

<target name="composer-diagnose">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ondrejmirtes

Not sure, should I add a task to download composer.phar instead?

I think it would be useful for being able to run phing locally, too.

What do you think?

@localheinz localheinz changed the title [WIP] Fix: Install composer.phar@1.6.5 Fix: Install composer.phar@1.6.5 Aug 4, 2018
@localheinz
Copy link
Contributor Author

Possibly fixed by composer/composer@a74b639.

@localheinz localheinz force-pushed the fix/composer-normalize branch 2 times, most recently from 9b66968 to c359438 Compare August 4, 2018 19:33
@localheinz localheinz changed the title Fix: Install composer.phar@1.6.5 Fix: Update composer itself to latest snapshot Aug 4, 2018
@localheinz
Copy link
Contributor Author

@ondrejmirtes

Updated!

@ondrejmirtes
Copy link
Member

When it's a part of Travis/Appveyor yamls, it does not need to be in build.xml 😊 I updated it.

@ondrejmirtes ondrejmirtes merged commit e4037d5 into phpstan:master Aug 5, 2018
@ondrejmirtes
Copy link
Member

Thanks!

@localheinz localheinz deleted the fix/composer-normalize branch August 5, 2018 20:42
@localheinz
Copy link
Contributor Author

Thank you, @ondrejmirtes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants