From 56c3878d2ebd4295d7953613675be8b03b913d99 Mon Sep 17 00:00:00 2001
From: Orazio <22700499+orazioedoardo@users.noreply.github.com>
Date: Sun, 11 Aug 2024 09:38:20 +0200
Subject: [PATCH] Replace inline onclick with addEventListener inside .js file
 to be compatible with CSP

Signed-off-by: Orazio <22700499+orazioedoardo@users.noreply.github.com>
---
 scripts/pi-hole/js/logout.js                | 6 ++++++
 scripts/pi-hole/lua/header_authenticated.lp | 3 ++-
 2 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 scripts/pi-hole/js/logout.js

diff --git a/scripts/pi-hole/js/logout.js b/scripts/pi-hole/js/logout.js
new file mode 100644
index 000000000..cffef77a2
--- /dev/null
+++ b/scripts/pi-hole/js/logout.js
@@ -0,0 +1,6 @@
+document.addEventListener("DOMContentLoaded", () => {
+  logout_button = document.getElementById("logout-button");
+  logout_button.addEventListener("click", () => {
+    utils.doLogout();
+  });
+});
diff --git a/scripts/pi-hole/lua/header_authenticated.lp b/scripts/pi-hole/lua/header_authenticated.lp
index f4a297f41..d27b80a27 100644
--- a/scripts/pi-hole/lua/header_authenticated.lp
+++ b/scripts/pi-hole/lua/header_authenticated.lp
@@ -9,6 +9,7 @@
 ]]--
 mg.include('header.lp','r')
 ?>
+    <script src="<?=pihole.fileversion('scripts/pi-hole/js/logout.js')?>"></script>
     <script src="<?=pihole.fileversion('scripts/vendor/select2.min.js')?>"></script>
     <script src="<?=pihole.fileversion('scripts/vendor/datatables.min.js')?>"></script>
     <script src="<?=pihole.fileversion('scripts/vendor/datatables.select.min.js')?>"></script>
@@ -85,7 +86,7 @@ mg.include('header.lp','r')
                                 <a class="btn-link" href="https://github.com/pi-hole" rel="noopener" target="_blank"><i class="fa-fw menu-icon fab fa-github"></i> GitHub</a>
                                 <a class="btn-link" href="https://discourse.pi-hole.net/c/announcements/5" rel="noopener" target="_blank"><i class="fa-fw menu-icon fa-solid fa-rocket"></i> Pi-hole Releases</a>
                                 <? if pihole.needLogin() then ?>
-                                <a class="btn-link" href="#" onclick="utils.doLogout();"><i class="fa-fw menu-icon fa-solid fa-arrow-right-from-bracket"></i> Log out</a>
+                                <a class="btn-link" href="#" id="logout-button"><i class="fa-fw menu-icon fa-solid fa-arrow-right-from-bracket"></i> Log out</a>
                                 <? end ?>
                             </li>
                         </ul>