Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(French) Errors in address splitting with numbered streets #24

Closed
arinstar opened this issue Mar 28, 2019 · 1 comment
Closed

(French) Errors in address splitting with numbered streets #24

arinstar opened this issue Mar 28, 2019 · 1 comment

Comments

@arinstar
Copy link

Hello,

When using this package to split French-language addresses, the following issue arises:

As stated in the docs, the street address 13 2ème Avenue will split correctly, and put 13 in houseNumber and 2ème Avenue in streetName.

array:5 [▼ "additionToAddress1" => "" "streetName" => "2ème Avenue" "houseNumber" => "13" "houseNumberParts" => array:2 [▼ "base" => "13" "extension" => "" ] "additionToAddress2" => "" ]

However, an issue arises when the shorter notation 13 2e Avenue is used. 13 2e will be flagged as houseNumber, in 2 parts. See the output below, from Laravel's dd() instruction :

Returned data:
array:5 [▼ "additionToAddress1" => "" "streetName" => "Avenue" "houseNumber" => "13 2e " "houseNumberParts" => array:2 [▼ "base" => "13" "extension" => "2e" ] "additionToAddress2" => "" ]

Expected data:
array:5 [▼ "additionToAddress1" => "" "streetName" => "2e Avenue" "houseNumber" => "13" "houseNumberParts" => array:2 [▼ "base" => "13" "extension" => "" ] "additionToAddress2" => "" ]

Here's an example of this address notation in Montreal, Canada:
https://www.google.com/maps/place/10e+Avenue,+Montr%C3%A9al,+QC/@45.5684289,-73.6242512,17z/data=!3m1!4b1!4m5!3m4!1s0x4cc91ed619691d27:0xd632287a8544ba86!8m2!3d45.5684252!4d-73.6220625

The shorter notation is what's typically provided by GIS systems which we have to validate against.

@svenmuennich
Copy link
Member

Thanks for the detailed issue description. This looks like a duplicate of #12. I added your example there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants