Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin maturin to use metadata 2.3 #144

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

piercefreeman
Copy link
Owner

@piercefreeman piercefreeman commented Dec 3, 2024

Our wheel publishing is currently failing with:

Checking dist/mountaineer-0.8.0.dev3-cp310-cp310-macosx_10_12_x86_64.whl: ERROR    InvalidDistribution: Metadata is missing required fields: Name,        
         Version.                                                               
         Make sure the distribution includes the files where those fields are   
         specified, and is using a supported Metadata-Version: 1.0, 1.1, 1.2,   
         2.0, 2.1, 2.2, 2.3.

This was caused by maturin's bump to 1.7.6, which now creates wheels that use metadata 2.4. Twine doesn't yet support this format so throws an error upon validation.

Pinned maturin ticket: PyO3/maturin#2335

Our CI pipeline automatically pulls the latest maturin version by inspecting any constraints placed within pypi - currently we just had any version maturin>=1.3.0 so CI was picking up the latest release before our own local development was:

https://github.com/PyO3/maturin-action/blob/bf4a58861cd84d5897c28635f47999d9882cdf33/src/index.ts#L352

This PR locks the maturin version to just below 1.7.6 until twine supports validation of higher numbered packages.

@piercefreeman piercefreeman added the Full Build Kick off a full build in CI label Dec 3, 2024
@piercefreeman piercefreeman force-pushed the feature/pin-twine-metadata-to-2-3 branch from 73bc928 to f9b89c9 Compare December 3, 2024 22:14
@piercefreeman piercefreeman merged commit 7595653 into main Dec 3, 2024
26 checks passed
@piercefreeman piercefreeman deleted the feature/pin-twine-metadata-to-2-3 branch December 3, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build Kick off a full build in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant