Merge pull request #18 from decentralion/enumerable-globals

ensure that globals includes process and console
pierrec · Jul 6, 2019 · 5135bfb · 5135bfb
2 parents ae48528 + 758db14
commit 5135bfb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/eval.js b/eval.js
@@ -36,6 +36,10 @@ module.exports = function (content, filename, scope, includeGlobals) {
 
   if (includeGlobals) {
     merge(sandbox, global)
+    // console is non-enumerable in node v10 and above
+    sandbox.console = global.console
+    // process is non-enumerable in node v12 and above
+    sandbox.process = global.process
     sandbox.require = requireLike(_filename)
   }
 

diff --git a/test.js b/test.js
@@ -27,4 +27,8 @@ assert.throws(function () {
     _eval('require("fs")')
 })
 
+// Verify that the console is available when globals are passed
+res = _eval('exports.x = console', true)
+assert.deepEqual(res.x, console)
+
 console.log('All tests passed')