Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Please rebuild for node 16 and release NAPI changes #115

Open
templela opened this issue Jul 27, 2022 · 6 comments
Open

Please rebuild for node 16 and release NAPI changes #115

templela opened this issue Jul 27, 2022 · 6 comments

Comments

@templela
Copy link

The changes have been made but a release hasn't happened yet. That would be really appreciated.

@vbatr
Copy link

vbatr commented Oct 26, 2022

@pierrec, is there a chance to get this library for newer node version?

@jubesab
Copy link

jubesab commented Feb 14, 2023

@pierrec It would be fantastic if you could update this package to work with newer version of nodes!

@pierrec
Copy link
Owner

pierrec commented Feb 27, 2023

Hello, sorry for the late response. I am no longer using Node and not following its updates/developments anymore.
I would accept a PR though to fix this issue!

@jubesab
Copy link

jubesab commented Feb 27, 2023

@pierrec I would happily contribute but I do not have the know how, unfortunately.

@Pysis868
Copy link

@templela Can you link commits?

@Pysis868
Copy link

Pysis868 commented Aug 11, 2024

@templela This one? a51c9e9.
There seem to be other useful commits already added to master too, which is probably what you were referring to.
Head is 943e768.

@pierrec Can you add a tag along with an NPM package update and build included?
I have this example if it helps:
https://github.com/Pysis868/node-lz4/releases/tag/v0.6.8
I'm still trying to get it to install into the other project successfully though..
The latest version was branched, and not merged into master, so I tried to unify it all.
I only upgraded the patch version number since only project internals/dependencies were changed, but maybe could warrant minor version upgrade(s) instead.

I arrived at this issue, looking for others, because another project required this one, where the latest version is 0.6.5, but building responded with errors like this:

  lz4_binding.cc
.../node-lz4\node_modules\nan\nan_callbacks .h(55,23): error C2039: 'AccessorSignature': is not a member of 'v8' [D:\Documents\Programmi ng\Others\Internet\Programming\node-lz4\build\lz4.vcxproj]

nodejs/nan#942

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants