Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named matching groups. #301

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

NorbertSzydlik
Copy link

Express 4.x crashes when using named capturing group in regexp (see expressjs/express#4277 ).
As far as I know, this feature have been added in newer version of path-to-regexp. It seems that it will land in Express 5.
This change aims to add the feature in current version of Express, which still uses path-to-regexp 0.1.x.

index.js Outdated Show resolved Hide resolved
@blakeembrey blakeembrey merged commit 114f62d into pillarjs:0.1.x Apr 7, 2024
@blakeembrey
Copy link
Member

blakeembrey commented Apr 7, 2024

Published as 0.1.8 although it could be a breaking change if people on the previous version were relying on it not matching in some way. The names do not change, only the index in the array, and only if they're using this feature of regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants