Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Minified javascript assets are not updated #505

Open
natted opened this issue Oct 11, 2023 · 2 comments
Open

[Bug]: Minified javascript assets are not updated #505

natted opened this issue Oct 11, 2023 · 2 comments

Comments

@natted
Copy link
Contributor

natted commented Oct 11, 2023

Expected behavior

cmf.min.js is a minified version of cmf.js

e.g. In your merged pull request (#504) you fixed cmf.js but did not update the cmf.min.js

Actual behavior

An old version of cmf.min.js exists. Looking at the file, the minified version in github hasn't been updated for 6 years. When testing this meant pimcore serves the outdated min.js file resulting in broken buttons in CMF for merge duplicates feature.

Steps to reproduce

Apply change as per PR 504 linked above.

Why would you not update the minified version when committing this kind of fix? Is pimcore meant to handle the minify process automatically?

@natted natted added the Bug label Oct 11, 2023
@dvesh3 dvesh3 added this to the 3.4.4 milestone Oct 13, 2023
@aryaantony92 aryaantony92 self-assigned this Oct 16, 2023
@aryaantony92
Copy link
Contributor

@natted Yes, the frontend assets for the admin (src/Resources/public/admin) is generated by gulp. And at the moment, we have some issues with the build generation. So, we fixed the issue with merge button in this PR #510 which is working in production mode. Thanks!

@kingjia90 kingjia90 modified the milestones: 3.4.4, 3.4.5 Nov 9, 2023
@kingjia90 kingjia90 removed this from the 3.4.5 milestone Jan 8, 2024
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

@fashxp fashxp added this to the 4.2.0 milestone Oct 2, 2024
@fashxp fashxp added the BC-BREAK label Oct 2, 2024
@fashxp fashxp modified the milestones: 4.2.0, 5.0.0 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants