You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
e.g. In your merged pull request (#504) you fixed cmf.js but did not update the cmf.min.js
Actual behavior
An old version of cmf.min.js exists. Looking at the file, the minified version in github hasn't been updated for 6 years. When testing this meant pimcore serves the outdated min.js file resulting in broken buttons in CMF for merge duplicates feature.
Steps to reproduce
Apply change as per PR 504 linked above.
Why would you not update the minified version when committing this kind of fix? Is pimcore meant to handle the minify process automatically?
The text was updated successfully, but these errors were encountered:
@natted Yes, the frontend assets for the admin (src/Resources/public/admin) is generated by gulp. And at the moment, we have some issues with the build generation. So, we fixed the issue with merge button in this PR #510 which is working in production mode. Thanks!
Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.
Expected behavior
cmf.min.js is a minified version of cmf.js
e.g. In your merged pull request (#504) you fixed cmf.js but did not update the cmf.min.js
Actual behavior
An old version of cmf.min.js exists. Looking at the file, the minified version in github hasn't been updated for 6 years. When testing this meant pimcore serves the outdated min.js file resulting in broken buttons in CMF for merge duplicates feature.
Steps to reproduce
Apply change as per PR 504 linked above.
Why would you not update the minified version when committing this kind of fix? Is pimcore meant to handle the minify process automatically?
The text was updated successfully, but these errors were encountered: