Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original customer id check #516

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Add original customer id check #516

merged 1 commit into from
Mar 22, 2024

Conversation

valentin-
Copy link
Contributor

Using custom save handlers with isOriginalCustomerNeeded enabled, creating users always fails as Pimcore 11 requires string|int but the id is still null.

Message: Pimcore\Model\DataObject\AbstractObject::getById(): Argument #1 ($id) must be of type string|int, null given
Trace: 
in /app/vendor/pimcore/pimcore/models/DataObject/AbstractObject.php:203
#0 [internal function]: Pimcore\Model\DataObject\AbstractObject::getById(NULL, Array)
#1 /app/vendor/pimcore/customer-management-framework-bundle/src/CustomerProvider/DefaultCustomerProvider.php(300): call_user_func_array(Array, Array)
#2 /app/vendor/pimcore/customer-management-framework-bundle/src/CustomerProvider/DefaultCustomerProvider.php(219): CustomerManagementFrameworkBundle\CustomerProvider\DefaultCustomerProvider->callStatic('getById', Array)
#3 /app/vendor/pimcore/customer-management-framework-bundle/src/CustomerSaveManager/DefaultCustomerSaveManager.php(132): CustomerManagementFrameworkBundle\CustomerProvider\DefaultCustomerProvider->getById(NULL, true)
#4 /app/vendor/pimcore/customer-management-framework-bundle/src/CustomerSaveManager/DefaultCustomerSaveManager.php(140): CustomerManagementFrameworkBundle\CustomerSaveManager\DefaultCustomerSaveManager->rememberOriginalCustomer(Object(App\Model\DataObject\User))

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

@markus-moser markus-moser added this to the 4.1.0 milestone Mar 22, 2024
@markus-moser markus-moser merged commit b586dee into pimcore:4.x Mar 22, 2024
@markus-moser
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants