Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stan to level 5 #40

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Bump stan to level 5 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
751cc87
Bump stan to level 5
dvesh3 Aug 4, 2023
930a3f6
Fix Stan
aryaantony92 Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
parameters:
level: 4
level: 5
reportUnmatchedIgnoredErrors: false
paths:
- src
Expand All @@ -9,4 +9,4 @@ parameters:
- src/Migrations/*
- src/Tests/*
includes:
- phpstan-baseline.neon
- phpstan-baseline.neon
2 changes: 2 additions & 0 deletions src/Controller/AdminController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ public function diffAction(Request $request): JsonResponse
$id1 = $request->get('id1');
$id2 = $request->get('id2');

/** @var Concrete $object1 */
$object1 = AbstractObject::getById(intval($id1));
/** @var Concrete $object2 */
$object2 = AbstractObject::getById(intval($id2));
Comment on lines +108 to 111
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** @var Concrete $object1 */
$object1 = AbstractObject::getById(intval($id1));
/** @var Concrete $object2 */
$object2 = AbstractObject::getById(intval($id2));
$object1 = Concrete::getById((int) $id1);
$object2 = Concrete::getById((int) $id2);
if (!$object1 || !$object2) {
throw $this->createNotFoundException();
}


// set the latest available version for editmode
Expand Down