Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

restore: retry scatter error #1402

Merged
merged 6 commits into from
Aug 5, 2021
Merged

Conversation

YuJuncen
Copy link
Collaborator

@YuJuncen YuJuncen commented Aug 3, 2021

What problem does this PR solve?

fix #1400

What is changed and how it works?

Add a retry on scatter failure, instead of giving up scattering the region directly.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

In a workload with little huge tables, many retries were captured.

image

Release note

  • Fix a bug that caused regions spread unbalanced after the restoration.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • zwj-coder

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

pkg/restore/split_client.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Aug 4, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Aug 5, 2021
@YuJuncen
Copy link
Collaborator Author

YuJuncen commented Aug 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a400f4b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scatter fails due to region "not-replicated"
4 participants