syncer: do not ignore fake rotate event to the next file (#1039) (#1041)

Co-authored-by: csuzhangxc <csuzhangxc@gmail.com> Co-authored-by: lance6716 <lance6716@gmail.com>
pingcap · Sep 16, 2020 · 651943d · 651943d
1 parent 5b3ad8a
commit 651943d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/syncer/syncer.go b/syncer/syncer.go
@@ -1497,9 +1497,10 @@ type eventContext struct {
 // TODO: Further split into smaller functions and group common arguments into
 // a context struct.
 func (s *Syncer) handleRotateEvent(ev *replication.RotateEvent, ec eventContext) error {
- if ec.header.Timestamp == 0 || ec.header.LogPos == 0 {
- // it is fake rotate event, ignore it
- return nil
+ if ec.header.Timestamp == 0 || ec.header.LogPos == 0 { // fake rotate event
+ if string(ev.NextLogName) <= ec.lastLocation.Position.Name {
+ return nil // not rotate to the next binlog file, ignore it
+ }
  }
 
  *ec.currentLocation = binlog.Location{