Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

tracker: get some session variables from downtream (#1032) #1071

Merged
merged 1 commit into from
Sep 22, 2020
Merged

tracker: get some session variables from downtream (#1032) #1071

merged 1 commit into from
Sep 22, 2020

Conversation

lance6716
Copy link
Collaborator

manually cherry-pick #1032

What problem does this PR solve?

enable some test about altering PK, and reduce user config. close #1003

What is changed and how it works?

  • session variable:
    • if user specified, use it
    • else get sql_mode, tidb_skip_utf8_check from downstream
  • tracker (tidb) config:
    • set alter-primary-key true
  • max-allow-packet
    • always get from downstream (by feature of driver)

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has persistent data change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

GMHDBJD
GMHDBJD reviewed Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 21, 2020
csuzhangxc
csuzhangxc approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit 7508475 into pingcap:release-2.0 Sep 22, 2020
@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated and removed status/LGT1 One reviewer already commented LGTM labels Sep 22, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 22, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Oct 27, 2020
@lance6716 lance6716 deleted the cp1032 branch July 6, 2021 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated already-update-release-note The release note is updated. Add this label once the release note is updated status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @csuzhangxc @GMHDBJD