Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

worker: sync master's endpoint peroidcally (#1139) #1180

Merged
merged 1 commit into from
Oct 17, 2020
Merged

worker: sync master's endpoint peroidcally (#1139) #1180

merged 1 commit into from
Oct 17, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1139 to release-2.0

What problem does this PR solve?

close #1110, part of #1127

What is changed and how it works?

use MemberList and GetClientURLs to get all master's endpoint

Check List

Tests

  • Integration test
  • Manual test
    check DEBUG message in log

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 @ti-srebot
cherry pick pingcap#1139 to release-2.0
826bd91 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 16, 2020
Merged
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) first-time-contributor labels Oct 16, 2020
csuzhangxc
csuzhangxc approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit aea4661 into pingcap:release-2.0 Oct 17, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated first-time-contributor priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @csuzhangxc @lance6716