Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

fix: do not block in load unit for stop/pause task (#1265) #1269

Merged
merged 1 commit into from
Nov 4, 2020
Merged

fix: do not block in load unit for stop/pause task (#1265) #1269

merged 1 commit into from
Nov 4, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1265 to release-2.0

What problem does this PR solve?

fix #1262

What is changed and how it works?

the receiver of chan continues to read (but drop the element if an error occurred) until the chan is closed or not more element.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@csuzhangxc @ti-srebot
cherry pick pingcap#1265 to release-2.0
6e2009b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 4, 2020
Merged
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) first-time-contributor labels Nov 4, 2020
csuzhangxc
csuzhangxc approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT2 Two reviewers already commented LGTM, ready for merge label Nov 4, 2020
@csuzhangxc csuzhangxc added this to the v2.0.1 milestone Nov 4, 2020
@csuzhangxc csuzhangxc merged commit 86e7e4c into pingcap:release-2.0 Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-srebot @csuzhangxc