-
Notifications
You must be signed in to change notification settings - Fork 188
Support migration data from source with different time_zone by default #1670
Conversation
/run-all-tests |
/run-unit-test |
we can't remove it because I remember there's a checking about undecoded config items, to fail the user of mistyping. (And I think this also disables smoothly downgrade from a version with more config items) |
we should log a warning if overwrite user's |
done |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a046f1e
|
/cherry-pick release-20. |
/cherry-pick release-2.0 |
In response to a cherrypick label: new pull request created: #1714. |
@lance6716: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/dm#release-2.0 from head ti-chi-bot:cherry-pick-1670-to-release-2.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-1670-to-release-2.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} |
@lance6716: new pull request could not be created: failed to create pull request against pingcap/dm#release-2.0 from head ti-chi-bot:cherry-pick-1670-to-release-2.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-1670-to-release-2.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Automatically adapt source and target DB time_zone settings so users don't need to explicitly set
timezone
in dm config.close #1691
What is changed and how it works?
timezone
setting in dm config. (maybe we should directly remove this config field)timezone='+00:00'
for all db connections in dumpling/loader/syncer.Check List
Tests
Code changes
Side effects
Related changes