Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Support migration data from source with different time_zone by default (#1670) #1714

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1670

What problem does this PR solve?

Automatically adapt source and target DB time_zone settings so users don't need to explicitly set timezone in dm config.

close #1691

What is changed and how it works?

  • Deprecated the timezone setting in dm config. (maybe we should directly remove this config field)
  • Always set timezone='+00:00' for all db connections in dumpling/loader/syncer.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot added first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/XXL status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0 labels May 21, 2021
@ti-chi-bot ti-chi-bot requested a review from GMHDBJD May 21, 2021 04:18
@ti-chi-bot ti-chi-bot requested a review from lance6716 May 21, 2021 04:19
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-1670-to-release-2.0 branch from 0541026 to c7b599c Compare May 21, 2021 04:19
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-1670-to-release-2.0 branch from c7b599c to a3b0244 Compare May 21, 2021 04:19
@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 21, 2021
@lance6716 lance6716 added the require-LGT1 for small PR, LGT1 is enough label May 21, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a3b0244

@ti-chi-bot ti-chi-bot merged commit 1fbb361 into pingcap:release-2.0 May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/XXL status/can-merge status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants