Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: fix the case-sensitive issue (#1738) #1886

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1738

What problem does this PR solve?

Fix the bug that case-sensitive can not take effect as expected.

What is changed and how it works?

  • Check upstream lower_case_table_names setting at bootstrap, do not allow set case-sensitive = true when lower_case_table_names = true
  • return schema/table name base on lower_case_table_names, return Name.O for 0, and Name.L for 1/2.
  • Try fix all the persistent data at syncer start if lower_case_table_names = 0

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has persistent data change

Side effects

  • Breaking backward compatibility
  • If the cluster is upgrade for a lower version with some upstream lower_case_table_names = 0, we can't rollback to the origin version since some persistent data has been changed.

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/XXL type/cherry-pick-for-release-2.0 labels Jul 19, 2021
@ti-chi-bot ti-chi-bot requested review from glorv and GMHDBJD July 19, 2021 10:10
@glorv
Copy link
Collaborator

glorv commented Jul 19, 2021

/run-all-tests

@lance6716
Copy link
Collaborator

merge conflict in tests/others_integration.txt

@ti-chi-bot ti-chi-bot added status/LGT1 One reviewer already commented LGTM needs-rebase labels Jul 22, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 26, 2021
@glorv
Copy link
Collaborator

glorv commented Jul 26, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 632e524

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1857994 into pingcap:release-2.0 Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/XXL status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick-for-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants