This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
loader, syncer: Update sql_mode to more compatible (#1869) #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
first-time-contributor
needs-update-release-note
glorv
reviewed
Jul 21, 2021
tests/others_integration.txt
Outdated
| @@ -10,3 +10,9 @@ load_task | |||
| downstream_more_column | |||
| expression_filter | |||
| fake_rotate_event | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
please resolve this conflict @okJiang
glorv
approved these changes
Jul 21, 2021
lance6716
approved these changes
Jul 22, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 8b4bab0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1869
What problem does this PR solve?
close #1735 and #1818
What is changed and how it works?
By add/delete some upstream's global.sql_mode to make downstream's sql_mode more compatible.
Check List
Tests
Code changes
Side effects
Related changes