This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: support sourceID on operate-source stop #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
needs-update-docs
GMHDBJD
reviewed
Aug 4, 2020
dm/ctl/master/operate_source.go
Outdated
| // the leading space could provide more friendly terminal printing | ||
| // cobra.Command doesn't support multi-line usage well | ||
| Use: `operate-source create|update [config-file ...] [--print-sample-config] [flags] | ||
| operate-source stop [config-file | sourceID ...] [--print-sample-config] [flags] |
There was a problem hiding this comment.
--print-sample-config cannot work with create/update/stop at the same time. But change to print-sample-config looks strange. 😖
There was a problem hiding this comment.
seems --print-sample-config will overwrite the running of create/update/stop/show, I guess user will only use --print-sample-config when they don't know how to write a config file (thus they can't do a right source operation), so it's not confusing.
going to change usage to
operate-source <operate-type> [config-file ...] [--print-sample-config]
GMHDBJD
added
status/LGT1
csuzhangxc
added
status/LGT2
lance6716
removed
needs-update-docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
part of #826
What is changed and how it works?
support sourceID on operate-source stop
Check List
Tests
Code changes
Side effects
Related changes