Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb: add description about GB18030 #18662

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

tidb: add description about GB18030 #18662

wants to merge 6 commits into from
+181 −96

Conversation

CbcWestwolf
Copy link
Member

What is changed, added or deleted? (Required)

Add description about GB18030

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 19, 2024
@lilin90 lilin90 self-assigned this Sep 20, 2024
@lilin90 lilin90 added v8.4 This PR/issue applies to TiDB v8.4. translation/doing This PR’s assignee is translating this PR. labels Sep 20, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 20, 2024
@lilin90 lilin90 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hfxsd
hfxsd reviewed Sep 23, 2024
View reviewed changes
character-set-gb18030.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 23, 2024
View reviewed changes
character-set-gb18030.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 23, 2024
View reviewed changes
character-set-gb18030.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 23, 2024
View reviewed changes
dm/dm-best-practices.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 13:32:44.88699319 +0000 UTC m=+1486434.627417141: ☑️ agreed by hfxsd.

@CbcWestwolf @hfxsd
Apply suggestions from code review
5bf0a04 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
lilin90
lilin90 reviewed Sep 24, 2024
View reviewed changes
character-set-gb18030.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Sep 24, 2024
View reviewed changes
character-set-gb18030.md Outdated Show resolved Hide resolved
character-set-gb18030.md Outdated Show resolved Hide resolved
character-set-gb18030.md Outdated Show resolved Hide resolved
character-set-gb18030.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Sep 24, 2024
View reviewed changes
sql-statements/sql-statement-show-collation.md Outdated
```

若开启了新排序规则框架，则在二进制排序规则之外，额外支持 `utf8_general_ci` 和 `utf8mb4_general_ci` 两种大小写和口音不敏感的排序规则：
若开启了新排序规则框架，则在二进制排序规则之外，额外支持若干种大小写和口音不敏感的排序规则：
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的“若干”指代能否更具体一些？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by 63942e5

@lilin90 lilin90 mentioned this pull request Sep 24, 2024
Open
16 tasks
CbcWestwolf and others added 2 commits September 25, 2024 10:31
@CbcWestwolf @lilin90
Apply suggestions from code review
1ad75f9 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@CbcWestwolf
update
63942e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@hfxsd hfxsd hfxsd approved these changes

Assignees

@lilin90 lilin90

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CbcWestwolf @lilin90 @hfxsd