Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync-diff-inspector: add limitations #19153

Merged
merged 4 commits into from
Nov 25, 2024
Merged

sync-diff-inspector: add limitations #19153

merged 4 commits into from
Nov 25, 2024

Conversation

pepezzzz
Copy link
Contributor

add some limitations.

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt Oreoxmt changed the title Update sync-diff-inspector-overview.md sync-diff-inspector: add limitations Nov 25, 2024
@Oreoxmt Oreoxmt self-assigned this Nov 25, 2024
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. labels Nov 25, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 25, 2024
@Oreoxmt Oreoxmt added missing-translation-status This PR does not have translation status info. area/sync-diff-inspector Indicates that the Issue or PR belongs to the area of sync-diff-inspector. labels Nov 25, 2024
pepezzzz and others added 2 commits November 25, 2024 14:10
@pepezzzz @Oreoxmt
Update sync-diff-inspector/sync-diff-inspector-overview.md
0ee9b35 
Co-authored-by: Aolin <aolinz@outlook.com>
@pepezzzz @Oreoxmt
Update sync-diff-inspector/sync-diff-inspector-overview.md
1c76c4c 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 25, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 06:11:03.908777461 +0000 UTC m=+444051.528431975: ☑️ agreed by Oreoxmt.

@Oreoxmt Oreoxmt removed missing-translation-status This PR does not have translation status info. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 25, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 25, 2024
Oreoxmt
Oreoxmt approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 25, 2024

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt Oreoxmt added the lgtm label Nov 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit a1c3ab9 into pingcap:master Nov 25, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19154.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19155.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #19156.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19157.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19158.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19159.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #19160.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
sync-diff-inspector: add limitations (#19153) (#19159)
cc61363
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
sync-diff-inspector: add limitations (#19153) (#19157)
578ce9e
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
sync-diff-inspector: add limitations (#19153) (#19155)
53b81cf
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
sync-diff-inspector: add limitations (#19153) (#19158)
33c192f
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
sync-diff-inspector: add limitations (#19153) (#19156)
ea32621
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
sync-diff-inspector: add limitations (#19153) (#19154)
223cb56
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
sync-diff-inspector: add limitations (#19153) (#19160)
6a6498a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@kennytm kennytm kennytm approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/sync-diff-inspector Indicates that the Issue or PR belongs to the area of sync-diff-inspector. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pepezzzz @Oreoxmt @ti-chi-bot @kennytm