Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update latin1 as an alias for utf8mb4 #9522

Closed
wants to merge 2 commits into from
Closed

update latin1 as an alias for utf8mb4 #9522

wants to merge 2 commits into from

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented May 18, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label May 18, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn May 18, 2022 06:52
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2022
@Defined2014 Defined2014 changed the title latin1: update latin1 charset information latin1: update latin1 as an alias for utf8mb4 in doc May 18, 2022
@Defined2014 Defined2014 changed the title latin1: update latin1 as an alias for utf8mb4 in doc update latin1 as an alias for utf8mb4 in doc May 18, 2022
@Defined2014 Defined2014 changed the title update latin1 as an alias for utf8mb4 in doc update latin1 as an alias for utf8mb4 May 18, 2022
basic-features.md Outdated Show resolved Hide resolved
Co-authored-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2022
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. v6.1 This PR/issue applies to TiDB v6.1. labels May 19, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 19, 2022
@TomShawn TomShawn added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label May 19, 2022
@ran-huang ran-huang added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. for-future-release This PR only applies to master for now and might cherry-pick to a future release. and removed v6.1 This PR/issue applies to TiDB v6.1. labels May 25, 2022
@TomShawn TomShawn removed status/LGT2 Indicates that a PR has LGTM 2. translation/doing This PR’s assignee is translating this PR. labels Jun 29, 2022
@TomShawn TomShawn removed first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-future-release This PR only applies to master for now and might cherry-pick to a future release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Jun 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. missing-translation-status This PR does not have translation status info. labels Jun 29, 2022
@TomShawn
Copy link
Contributor

The related code has been reverted and there is no release plan for this feature.

@Defined2014 Defined2014 deleted the latin1 branch November 24, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing-translation-status This PR does not have translation status info. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants