Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-compatibility: update ZERO_DATE docs #4436

Merged
merged 3 commits into from
Dec 22, 2020

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Dec 17, 2020

First-time contributors' checklist

What is changed, added or deleted? (Required)

The behavior of zero_date changed in master to be more mysql compatibility. This has not been backported.

There are some minor exceptions still, since DDL changes can still produce invalid dates (see: pingcap/tidb#21564 ). But I think these are minor, and it is worth updating the docs since the main workflow as described (INSERT/UPDATE) now matches MySQL.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

pingcap/tidb#20206

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@morgo
Copy link
Contributor Author

morgo commented Dec 17, 2020

PTAL @9547 @lzmhhh123

Thanks!

@TomShawn TomShawn added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR's assignee is translating this PR. labels Dec 18, 2020
@TomShawn TomShawn requested review from lzmhhh123 and removed request for zz-jason December 18, 2020 02:48
Copy link

@9547 9547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-srebot
Copy link
Contributor

@9547, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2020
@ti-srebot
Copy link
Contributor

@9547, @TomShawn, @lzmhhh123, PTAL.

@morgo
Copy link
Contributor Author

morgo commented Dec 22, 2020

/merge

@ti-srebot
Copy link
Contributor

@morgo Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1

@TomShawn TomShawn merged commit 468a2ec into pingcap:master Dec 22, 2020
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Dec 23, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants