Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: add doc for integrating with Confluent #9866

Merged
merged 9 commits into from
Aug 12, 2022
Merged

ticdc: add doc for integrating with Confluent #9866

merged 9 commits into from
Aug 12, 2022

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Aug 7, 2022 •
edited by zhangyangyu
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

This PR translated one doc of pingcap/docs-cn#10276: ticdc/integrate-confluent-using-ticdc.md

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 7, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Aug 8, 2022
zier-one
zier-one approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangyangyu zhangyangyu mentioned this pull request Aug 10, 2022
Closed
ran-huang
ran-huang reviewed Aug 11, 2022
View reviewed changes
ticdc/integrate-confluent-using-ticdc.md Outdated Show resolved Hide resolved
ticdc/integrate-confluent-using-ticdc.md Outdated Show resolved Hide resolved
ticdc/integrate-confluent-using-ticdc.md Outdated Show resolved Hide resolved
ticdc/integrate-confluent-using-ticdc.md Outdated Show resolved Hide resolved
ticdc/integrate-confluent-using-ticdc.md Outdated Show resolved Hide resolved
ticdc/integrate-confluent-using-ticdc.md Outdated Show resolved Hide resolved
ticdc/integrate-confluent-using-ticdc.md Outdated Show resolved Hide resolved
@shichun-0415 @ran-huang
Apply suggestions from code review
eb6f38e 
Co-authored-by: Ran <huangran@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2022
@shichun-0415
Copy link
Contributor Author

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 12, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a18c927

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2022
@ti-chi-bot ti-chi-bot merged commit 39c3964 into pingcap:master Aug 12, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9958.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 12, 2022
Merged
13 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 12, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9959.

@shichun-0415 shichun-0415 deleted the integrate-with-confluent branch August 12, 2022 11:28
ti-chi-bot added a commit that referenced this pull request Aug 12, 2022
@ti-chi-bot
ticdc: add doc for integrating with Confluent (#9866) (#9959)
43a1f10
shichun-0415 added a commit that referenced this pull request Aug 12, 2022
@ti-chi-bot @shichun-0415 @ran-huang
ticdc: add doc for integrating with Confluent (#9866) (#9958)
55dbeef 
* ticdc: add doc for integrating with Confluent

* lint

* format

* fix figure text inconsistency

* Delete sql-server-configuration.png

* address comments and refine wording

* Apply suggestions from code review

Co-authored-by: Ran <huangran@pingcap.com>

* sync Chinese

* bump version to v6.2

* change ctl version to 6.1

Co-authored-by: shichun-0415 <lishichun@pingcap.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Aug 12, 2022
@ran-huang
Revert "ticdc: add doc for integrating with Confluent (#9866) (#9958)"
aef0230 
This reverts commit 55dbeef.
ran-huang added a commit that referenced this pull request Aug 12, 2022
@ran-huang
Revert "ticdc: add doc for integrating with Confluent (#9866) (#9958)" (
6070629 
#9962)

This reverts commit 55dbeef.
ran-huang added a commit that referenced this pull request Aug 12, 2022
@ran-huang
Revert "Revert "ticdc: add doc for integrating with Confluent (#9866) (…
808a9e6 
…#9958)" (#9962)"

This reverts commit 6070629.
ti-chi-bot pushed a commit that referenced this pull request Aug 12, 2022
@ran-huang
Revert "Revert "ticdc: add doc for integrating with Confluent (#9866)…
4324d8f 
…"" (#9964)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees
No one assigned
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shichun-0415 @ti-chi-bot @zhangyangyu @zier-one @ran-huang