avoid creating duplicate stack traces #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gregwebs , we need make a decisioin how to identity duplicate stack~? there will be much |
|
expect that, we meet other problem, tidb has too many pending PR and we prefer rename some method name of pkg/errors to decrease old code modification. e.g.
can we do them in this repo, how do you think abouth it~? 🐱 |
This is done by using the new AddStack function instead of WithStack. There is also a StackError utility function exposed.
gregwebs
force-pushed
the
dedup-stack-traces
branch
from
792d14a
to
0a61de8
Compare
|
Sounds good. Addressed in this PR: https://github.com/lysu/errors/pull/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by using the new AddStack function instead of WithStack.
There is also a StackError utility function exposed.