*: add admin cleanup table lock syntax support #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
force-pushed
the
clean_table_lock
branch
from
4c34b71
to
690470b
Compare
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
- Coverage 50.65% 50.51% -0.14%
==========================================
Files 31 31
Lines 6890 6909 +19
==========================================
Hits 3490 3490
- Misses 3041 3060 +19
Partials 359 359
Continue to review full report at Codecov.
|
kennytm
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
LGTM.
But I just realized there's a TableName: Identifier '.' '*' rule, meaning all of the following are valid:
admin cleanup table lock a.*;
-- equivalent to admin cleanup table lock a;
admin checksum table a.*;
-- equivalent to admin checksum table a;
admin check table a.*;
-- equivalent to admin check table a;
analyze table a.*;
-- equivalent to analyze table a;Are these all expected? 👀
Edit: I filed #357 for this.
lzmhhh123
pushed a commit
to lzmhhh123/parser
that referenced
this pull request
Jan 17, 2020
lzmhhh123
added a commit
that referenced
this pull request
Jan 17, 2020
lzmhhh123
pushed a commit
to lzmhhh123/parser
that referenced
this pull request
Jan 17, 2020
crazycs520
added a commit
to crazycs520/parser
that referenced
this pull request
Apr 28, 2020
crazycs520
added a commit
to crazycs520/parser
that referenced
this pull request
Apr 28, 2020
kennytm
pushed a commit
that referenced
this pull request
Apr 28, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add cleanup table lock syntax:
Please merge PR: #305 first.
What is changed and how it works?
Check List
Tests
Code changes