Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: suport alter table set flash replica syntax #564

Merged
merged 11 commits into from
Oct 21, 2019
Merged

*: suport alter table set flash replica syntax #564

merged 11 commits into from
Oct 21, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

This is for TiDB PR: pingcap/tidb#12453

  • Add DDL syntax to support add table flash replica.
ALTER TABLE [table_name] SET FLASH REPLICA [count] LOCATION LABELS [location_labels]
eg:
ALTER TABLE t SET FLASH REPLICA 3 LOCATION LABELS "rack", "host", "abc";

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@crazycs520 crazycs520 mentioned this pull request Sep 27, 2019
Merged
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #564 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   71.78%   71.82%   +0.03%     
==========================================
  Files          32       32              
  Lines        7858     7868      +10     
==========================================
+ Hits         5641     5651      +10     
  Misses       1681     1681              
  Partials      536      536
Impacted Files Coverage Δ
model/model.go 48.93% <ø> (ø) ⬆️
parser.go 70.37% <ø> (ø) ⬆️
model/ddl.go 76.99% <ø> (ø) ⬆️
misc.go 96.49% <ø> (ø) ⬆️
ast/ddl.go 80.26% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 646d641...4d53ab2. Read the comment docs.

kennytm
kennytm reviewed Sep 27, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Sep 27, 2019
@crazycs520 crazycs520 requested a review from a team October 21, 2019 05:50
lzmhhh123
lzmhhh123 approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Oct 21, 2019
@lzmhhh123 lzmhhh123 merged commit 488522f into pingcap:master Oct 21, 2019
lzmhhh123 pushed a commit to lzmhhh123/parser that referenced this pull request Jan 17, 2020
@crazycs520 @lzmhhh123
*: suport alter table set flash replica syntax (pingcap#564)
0dfe81a
@lzmhhh123 lzmhhh123 mentioned this pull request Jan 17, 2020
Merged
lzmhhh123 pushed a commit to lzmhhh123/parser that referenced this pull request Jan 17, 2020
@crazycs520 @lzmhhh123
*: suport alter table set flash replica syntax (pingcap#564)
7166a7b
lzmhhh123 added a commit that referenced this pull request Jan 17, 2020
@lzmhhh123 @crazycs520
*: suport alter table set flash replica syntax (#564) (#716)
923ffb7 
* *: try to support lock/unlock tables function (#305)

* *: add admin cleanup table lock syntax (#323)

* *: support alter table set flash replica syntax (#564)

Co-authored-by: crazycs <crazycs520@gmail.com>
lzmhhh123 pushed a commit to lzmhhh123/parser that referenced this pull request Jan 17, 2020
@crazycs520 @lzmhhh123
*: suport alter table set flash replica syntax (pingcap#564)
1aed1a5
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@crazycs520 @lzmhhh123
*: suport alter table set flash replica syntax (pingcap#564)
a59c503
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@crazycs520 @lzmhhh123
*: suport alter table set flash replica syntax (pingcap#564)
489991f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazycs520 @kennytm @lzmhhh123