server: GetAllStores should not return tombstone stores (#1440) #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1 |
nolouch
added
the
do-not-merge/work-in-progress
|
pingcap/kvproto#361 has been merged, could you update kvproto? |
nolouch
force-pushed
the
pick-1440
branch
2 times, most recently
from
4b84d0d
to
2b8af24
Compare
* server: add option to exclude tombstone stores GetAllStores should not return tombstone stores in most cases. We can add an option to support that if we needs it later. Signed-off-by: Huachao Huang <huachao.huang@gmail.com>
nolouch
removed
the
do-not-merge/work-in-progress
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1 |
1 similar comment
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1 |
|
/rebuild |
1 similar comment
|
/rebuild |
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1 |
|
/rebuild |
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1 |
1 similar comment
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1 |
rleungx
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry pick #1440