Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule: combine store limit and store balance rate (#2437) #2557

Merged
merged 1 commit into from
Jun 19, 2020
Merged

schedule: combine store limit and store balance rate (#2437) #2557

merged 1 commit into from
Jun 19, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 19, 2020

What problem does this PR solve?

cherry-pick #2437.

What is changed and how it works?

This PR mainly does these things:

  • remove store-balance-rate
  • persist store limit in schedule config
  • change the auto store limit policy
  • rename *region to *peer
  • move RemoveScheduler from Options to Cluster interface
  • some updates for testing and doc.

Check List

Tests

  • Unit test

Release note

  • Improve the way to set store limit by removing store-balance-rate

@rleungx
schedule: combine store limit and store balance rate (tikv#2437)
15c704e 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added this to the v4.0.2 milestone Jun 19, 2020
@rleungx rleungx requested review from nolouch and lhy1024 June 19, 2020 02:54
@lhy1024
Copy link
Contributor

lhy1024 commented Jun 19, 2020

/approve

ti-srebot
ti-srebot approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhy1024
lhy1024 reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@rleungx
Copy link
Member Author

rleungx commented Jun 19, 2020

/run-all-tests

@rleungx
Copy link
Member Author

rleungx commented Jun 19, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 19, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

@rleungx
Copy link
Member Author

rleungx commented Jun 19, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@rleungx
Copy link
Member Author

rleungx commented Jun 19, 2020

/rebuild

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

@rleungx
Copy link
Member Author

rleungx commented Jun 19, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 0534436 into tikv:release-4.0 Jun 19, 2020
@nolouch nolouch added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 left review comments

@nolouch nolouch nolouch approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
v4.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @lhy1024 @ti-srebot @nolouch