Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

scripts: update DDL metrics #508

Merged
merged 2 commits into from
Sep 11, 2018
Merged

scripts: update DDL metrics #508

merged 2 commits into from
Sep 11, 2018

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Aug 23, 2018

Add job action and schema version information to DDL metrics.

Merge after pingcap/tidb#7472

screen shot 2018-08-28 at 10 46 37
screen shot 2018-08-28 at 10 46 46

@zimulala zimulala changed the title scripts: update DDL metrics [DNM]scripts: update DDL metrics Aug 23, 2018
@zimulala zimulala changed the title [DNM]scripts: update DDL metrics scripts: update DDL metrics Aug 28, 2018
@zimulala
Copy link
Contributor Author

PTAL @tiancaiamao @coocood

@shenli
Copy link
Member

shenli commented Aug 28, 2018

Could you post the screenshot here?

@zimulala
Copy link
Contributor Author

@shenli Done.

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

version as label? will it generate too much of labels and difficult to show in the grafana ?

@tiancaiamao
Copy link
Contributor

LGTM @winkyao

@coocood
Copy link
Member

coocood commented Sep 11, 2018

LGTM

@coocood coocood merged commit ed9770e into pingcap:master Sep 11, 2018
@zimulala zimulala deleted the ddl-metrics branch September 11, 2018 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants