Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the performance of bidirectional synchronous update table of _drainer_repl_mark (#903) #909

Merged
merged 7 commits into from
Feb 24, 2020

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Feb 24, 2020

cherry-pick #903 to release-3.0


…of _drainer_repl_mark

What problem does this PR solve?

1.Optimize the performance of bidirectional synchronous update table of _drainer_repl_mark

What is changed and how it works?

The number of channel related records in the mark table is initialized according to the number of worker "count. During synchronization, each syncer operates one piece of data, which will not cause multithreading to update one record, resulting in synchronization performance bottleneck

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@WangXiangUSTC
Copy link
Contributor

LGTM

@sre-bot
Copy link
Author

sre-bot commented Feb 24, 2020

/run-all-tests

@sre-bot sre-bot merged commit 51b82e1 into pingcap:release-3.0 Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants