Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

restore: write index kv pairs and data kv pairs to separate engine #132

Merged
merged 11 commits into from
Mar 8, 2019
Merged

restore: write index kv pairs and data kv pairs to separate engine #132

merged 11 commits into from
Mar 8, 2019

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Feb 16, 2019 •
edited
Loading

What problem does this PR solve?

Write index kvs and data kvs to separate engine. See: #137

What is changed and how it works?

Use different engine file.

Check List

Tests

  • Unit test
  • Integration test

Side effects

Related changes

@lonng
Copy link
Contributor Author

lonng commented Feb 16, 2019

/run-all-tests

@lonng lonng added the status/DNM Do not merge, test is failing or blocked by another PR label Feb 16, 2019
@lonng lonng changed the title restore: write index kvs and data kvs to separate engine [POC]restore: write index kvs and data kvs to separate engine Feb 16, 2019
@lonng
Copy link
Contributor Author

lonng commented Feb 18, 2019

/run-all-tests

1 similar comment
@lonng
Copy link
Contributor Author

lonng commented Feb 20, 2019

/run-all-tests

@lonng
Copy link
Contributor Author

lonng commented Mar 4, 2019

/run-all-tests

@lonng lonng added the Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated label Mar 4, 2019
@lonng lonng changed the title [POC]restore: write index kvs and data kvs to separate engine restore: write index kv pairs and data kv pairs to separate engine Mar 5, 2019
@lonng lonng added status/PTAL This PR is ready for review. Add this label back after committing new changes type/feature New feature and removed status/DNM Do not merge, test is failing or blocked by another PR status/WIP Work in progress labels Mar 5, 2019
@lonng
Copy link
Contributor Author

lonng commented Mar 5, 2019

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/rebuild

@lonng
Copy link
Contributor Author

lonng commented Mar 5, 2019

@kennytm PTAL

@IANTHEREAL
Copy link
Collaborator

can we creare an issue for Proposal#4 ？

@lonng lonng mentioned this pull request Mar 6, 2019
Closed
@lonng
Copy link
Contributor Author

lonng commented Mar 6, 2019

@GregoryIan PTAL

IANTHEREAL
IANTHEREAL reviewed Mar 6, 2019
View reviewed changes
lightning/restore/checkpoints.go Outdated Show resolved Hide resolved
lightning/restore/checkpoints.go Outdated Show resolved Hide resolved
lightning/restore/checkpoints.go Show resolved Hide resolved
lightning/restore/checkpoints.go Outdated Show resolved Hide resolved
lightning/restore/restore.go Show resolved Hide resolved
lightning/restore/restore.go Outdated Show resolved Hide resolved
lightning/restore/restore.go Show resolved Hide resolved
lightning/restore/restore.go Show resolved Hide resolved
kennytm
kennytm reviewed Mar 6, 2019
View reviewed changes
lightning/config/config.go Outdated Show resolved Hide resolved
lightning/restore/file_checkpoints.proto Outdated Show resolved Hide resolved
lightning/restore/restore.go Outdated Show resolved Hide resolved
@lonng
Copy link
Contributor Author

lonng commented Mar 6, 2019

/run-all-tests

@IANTHEREAL
Copy link
Collaborator

LGTM

@lonng lonng added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Mar 7, 2019
kennytm
kennytm reviewed Mar 7, 2019
View reviewed changes
lightning/config/config.go Outdated Show resolved Hide resolved
lightning/restore/file_checkpoints.proto Outdated Show resolved Hide resolved
@lonng
Copy link
Contributor Author

lonng commented Mar 8, 2019

/run-all-tests

kennytm
kennytm reviewed Mar 8, 2019
View reviewed changes
lightning/restore/checkpoints.go Outdated Show resolved Hide resolved
lightning/restore/file_checkpoints.proto Outdated Show resolved Hide resolved
lightning/restore/file_checkpoints.proto Outdated Show resolved Hide resolved
lightning/restore/restore.go Outdated Show resolved Hide resolved
lightning/restore/restore.go Outdated Show resolved Hide resolved
lightning/restore/restore.go Outdated Show resolved Hide resolved
lightning/restore/restore.go Outdated Show resolved Hide resolved
lightning/restore/restore.go Outdated Show resolved Hide resolved
lightning/restore/restore.go Outdated Show resolved Hide resolved
@lonng
Copy link
Contributor Author

lonng commented Mar 8, 2019

/run-all-tests

kennytm
kennytm approved these changes Mar 8, 2019
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) Should Update Ansible The config in TiDB-Ansible should be updated and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Mar 8, 2019
@kennytm kennytm merged commit 9b71f1c into pingcap:master Mar 8, 2019
@lonng lonng deleted the index-engine-poc branch March 8, 2019 10:08
@kennytm kennytm removed Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated Should Update Ansible The config in TiDB-Ansible should be updated labels Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lonng @zhouqiang-cl @IANTHEREAL @kennytm