From c6f2ea35452be64cb9249028f65d8967d258228b Mon Sep 17 00:00:00 2001
From: Greg Weber <greg@gregweber.info>
Date: Tue, 9 Apr 2019 17:28:42 -0700
Subject: [PATCH 1/2] marketplace update

document the service account
fix some issues with the manual install
---
 marketplace/gcp/tidb-operator/README.md              | 10 +++++++++-
 marketplace/gcp/tidb-operator/manifests/app-crd.yaml |  5 -----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/marketplace/gcp/tidb-operator/README.md b/marketplace/gcp/tidb-operator/README.md
index 42e6f52381..4a18fa415a 100644
--- a/marketplace/gcp/tidb-operator/README.md
+++ b/marketplace/gcp/tidb-operator/README.md
@@ -1,3 +1,11 @@
+# GKE service account
+
+If you install on GKE, please select the option to create a new service account.
+The default service account may not have the required permissions.
+
+
+# Manual installation
+
 First you can modify configuration values.
 
 * schema.yaml: don't modify this, use parameters to override it as shown below
@@ -24,7 +32,7 @@ NAMESPACE=tidb
 # We strongly recommend deploying into a new namespace
 kubectl create namespace $NAMESPACE
 
-REGISTRY=$REGISTRY NAMESPACE=$NAMESPACE ./scripts/install
+REGISTRY=$REGISTRY NAMESPACE=$NAMESPACE VERSION=$VERSION ./scripts/install
 ```
 
 You can watch the deployment come up with
diff --git a/marketplace/gcp/tidb-operator/manifests/app-crd.yaml b/marketplace/gcp/tidb-operator/manifests/app-crd.yaml
index 6983f49d6e..0b14d4d41e 100644
--- a/marketplace/gcp/tidb-operator/manifests/app-crd.yaml
+++ b/marketplace/gcp/tidb-operator/manifests/app-crd.yaml
@@ -131,8 +131,3 @@ spec:
           type: object
       type: object
   version: v1beta1
-status:
-  acceptedNames:
-    kind: ""
-    plural: ""
-  conditions: null

From 04799a8cd99177b42e41c19524851e2982634a5e Mon Sep 17 00:00:00 2001
From: Greg Weber <greg@gregweber.info>
Date: Tue, 9 Apr 2019 18:01:17 -0700
Subject: [PATCH 2/2] add a note on deletion

---
 marketplace/gcp/tidb-operator/README.md | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/marketplace/gcp/tidb-operator/README.md b/marketplace/gcp/tidb-operator/README.md
index 4a18fa415a..e64894a1ec 100644
--- a/marketplace/gcp/tidb-operator/README.md
+++ b/marketplace/gcp/tidb-operator/README.md
@@ -3,6 +3,16 @@
 If you install on GKE, please select the option to create a new service account.
 The default service account may not have the required permissions.
 
+# Deletion
+
+In the below, tidb is installed into the namespace "tidb".
+Deleting the application will not delete the pods. You should delete the namespace and then delete the persistent volumes.
+
+```
+kubectl delete namespace tidb
+kubectl get pv -l app.kubernetes.io/namespace=$NAMESPACE -o name | xargs -I {} kubectl patch {} -p '{"spec":{"persistentVolumeReclaimPolicy":"Delete"}}'
+```
+
 
 # Manual installation