diff --git a/charts/tidb-backup/values.yaml b/charts/tidb-backup/values.yaml index 257c306a6d..b240ba2ec7 100644 --- a/charts/tidb-backup/values.yaml +++ b/charts/tidb-backup/values.yaml @@ -41,8 +41,11 @@ storage: className: local-storage size: 100Gi -# backupOptions is the options of mydumper https://github.com/maxbube/mydumper/blob/master/docs/mydumper_usage.rst#options -backupOptions: "--verbose=3" +# -t is thread count, larger thread count will speed up the backup, but may impact the performance of the upstream TiDB. +# -F is the chunk size, a big table is partitioned into many chunks. +# Other useful options are -B for database, and -T for tables. +# See https://github.com/maxbube/mydumper/blob/master/docs/mydumper_usage.rst#options for more options. +backupOptions: "-t 16 -F 256 --skip-tz-utc --verbose=3" # Set the tidb_snapshot to be used for the backup # Use `show master status` to get the ts: # MySQL [(none)]> show master status; diff --git a/charts/tidb-cluster/values.yaml b/charts/tidb-cluster/values.yaml index 7effd70bf7..8989db189a 100644 --- a/charts/tidb-cluster/values.yaml +++ b/charts/tidb-cluster/values.yaml @@ -519,8 +519,11 @@ scheduledBackup: failedJobsHistoryLimit: 1 # https://kubernetes.io/docs/tasks/job/automated-tasks-with-cron-jobs/#starting-deadline startingDeadlineSeconds: 3600 - # https://github.com/maxbube/mydumper/blob/master/docs/mydumper_usage.rst#options - options: "--verbose=3" + # -t is thread count, larger thread count will speed up the backup, but may impact the performance of the upstream TiDB. + # -F is the chunk size, a big table is partitioned into many chunks. + # Other useful options are -B for database, and -T for tables. + # See https://github.com/maxbube/mydumper/blob/master/docs/mydumper_usage.rst#options for more options. + options: "-t 16 -F 256 --skip-tz-utc --verbose=3" # secretName is the name of the secret which stores user and password used for backup # Note: you must give the user enough privilege to do the backup # you can create the secret by: diff --git a/tests/actions.go b/tests/actions.go index 6f4d5b2d61..14720bb242 100644 --- a/tests/actions.go +++ b/tests/actions.go @@ -1818,7 +1818,6 @@ func (oa *operatorActions) DeployAdHocBackup(info *TidbClusterConfig) error { "user": "root", "password": info.Password, "storage.size": "10Gi", - "backupOptions": "\"--verbose=3\"", "initialCommitTs": strings.TrimSpace(tsStr), }