From 2d23240b376a65444f8b127200cda1d595c121e4 Mon Sep 17 00:00:00 2001 From: SeaRise Date: Tue, 1 Aug 2023 17:34:16 +0800 Subject: [PATCH] sessionctx: set tiflash pipeline model to true by default (#45516) close pingcap/tidb#45618 --- sessionctx/variable/session.go | 2 +- sessionctx/variable/tidb_vars.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sessionctx/variable/session.go b/sessionctx/variable/session.go index a05139024daa4..88fdeaba32040 100644 --- a/sessionctx/variable/session.go +++ b/sessionctx/variable/session.go @@ -885,7 +885,7 @@ type SessionVars struct { TiFlashMaxBytesBeforeExternalSort int64 // TiFlashEnablePipelineMode means if we should use pipeline model to execute query or not in tiflash. - // Default value is `false`, means never use pipeline model in tiflash. + // Default value is `true`, means never use pipeline model in tiflash. // Value set to `true` means try to execute query with pipeline model in tiflash. TiFlashEnablePipelineMode bool diff --git a/sessionctx/variable/tidb_vars.go b/sessionctx/variable/tidb_vars.go index ae0ae50a6231a..89159050c2f5e 100644 --- a/sessionctx/variable/tidb_vars.go +++ b/sessionctx/variable/tidb_vars.go @@ -411,7 +411,7 @@ const ( TiDBMaxBytesBeforeTiFlashExternalSort = "tidb_max_bytes_before_tiflash_external_sort" // TiDBEnableTiFlashPipelineMode means if we should use pipeline model to execute query or not in tiflash. - // Default value is `false`, means never use pipeline model in tiflash. + // Default value is `true`, means never use pipeline model in tiflash. // Value set to `true` means try to execute query with pipeline model in tiflash. TiDBEnableTiFlashPipelineMode = "tidb_enable_tiflash_pipeline_model" @@ -1170,7 +1170,7 @@ const ( DefTiFlashMaxBytesBeforeExternalJoin = -1 DefTiFlashMaxBytesBeforeExternalGroupBy = -1 DefTiFlashMaxBytesBeforeExternalSort = -1 - DefTiDBEnableTiFlashPipelineMode = false + DefTiDBEnableTiFlashPipelineMode = true DefTiDBMPPStoreFailTTL = "60s" DefTiDBTxnMode = "" DefTiDBRowFormatV1 = 1