From 981fc3b1c2857721ddd0cc9dc588e26d1472820b Mon Sep 17 00:00:00 2001 From: Ti Chi Robot Date: Mon, 16 Oct 2023 12:28:58 +0800 Subject: [PATCH] planner: fix index heuristic rule will prune out hint preferred tiflash path (#46102) (#46145) close pingcap/tidb#40146 --- planner/core/casetest/enforce_mpp_test.go | 7 +++++++ .../core/casetest/testdata/enforce_mpp_suite_in.json | 3 ++- .../core/casetest/testdata/enforce_mpp_suite_out.json | 11 +++++++++++ planner/core/stats.go | 9 ++++++++- 4 files changed, 28 insertions(+), 2 deletions(-) diff --git a/planner/core/casetest/enforce_mpp_test.go b/planner/core/casetest/enforce_mpp_test.go index 9e94d58a7ca10..80d99cef06438 100644 --- a/planner/core/casetest/enforce_mpp_test.go +++ b/planner/core/casetest/enforce_mpp_test.go @@ -39,6 +39,7 @@ func TestEnforceMPP(t *testing.T) { tk.MustExec("drop table if exists t") tk.MustExec("create table t(a int, b int)") tk.MustExec("create index idx on t(a)") + tk.MustExec("CREATE TABLE `s` (\n `a` int(11) DEFAULT NULL,\n `b` int(11) DEFAULT NULL,\n `c` int(11) DEFAULT NULL,\n `d` int(11) DEFAULT NULL,\n UNIQUE KEY `a` (`a`),\n KEY `ii` (`a`,`b`)\n)") // Default RPC encoding may cause statistics explain result differ and then the test unstable. tk.MustExec("set @@tidb_enable_chunk_rpc = on") @@ -55,6 +56,12 @@ func TestEnforceMPP(t *testing.T) { Available: true, } } + if tblInfo.Name.L == "s" { + tblInfo.TiFlashReplica = &model.TiFlashReplicaInfo{ + Count: 1, + Available: true, + } + } } var input []string diff --git a/planner/core/casetest/testdata/enforce_mpp_suite_in.json b/planner/core/casetest/testdata/enforce_mpp_suite_in.json index 0933bec1be912..1ba049a0a0936 100644 --- a/planner/core/casetest/testdata/enforce_mpp_suite_in.json +++ b/planner/core/casetest/testdata/enforce_mpp_suite_in.json @@ -21,7 +21,8 @@ "set @@tidb_enforce_mpp=1;", "explain format='verbose' select count(*) from t where a=1", "explain format='verbose' select /*+ read_from_storage(tikv[t]) */ count(*) from t where a=1", - "explain format='verbose' select /*+ read_from_storage(tiflash[t]) */ count(*) from t where a=1" + "explain format='verbose' select /*+ read_from_storage(tiflash[t]) */ count(*) from t where a=1", + "explain select /*+ READ_FROM_STORAGE(TIFLASH[s]) */ a from s where a = 10 and b is null; -- index path huristic rule will prune tiflash path" ] }, { diff --git a/planner/core/casetest/testdata/enforce_mpp_suite_out.json b/planner/core/casetest/testdata/enforce_mpp_suite_out.json index 0811c86a3c7e2..74a9ffbdf6685 100644 --- a/planner/core/casetest/testdata/enforce_mpp_suite_out.json +++ b/planner/core/casetest/testdata/enforce_mpp_suite_out.json @@ -173,6 +173,17 @@ " └─TableFullScan_25 10000.00 928000.00 batchCop[tiflash] table:t pushed down filter:empty, keep order:false, stats:pseudo" ], "Warn": null + }, + { + "SQL": "explain select /*+ READ_FROM_STORAGE(TIFLASH[s]) */ a from s where a = 10 and b is null; -- index path huristic rule will prune tiflash path", + "Plan": [ + "TableReader_12 0.10 root MppVersion: 1, data:ExchangeSender_11", + "└─ExchangeSender_11 0.10 mpp[tiflash] ExchangeType: PassThrough", + " └─Projection_5 0.10 mpp[tiflash] test.s.a", + " └─Selection_10 0.10 mpp[tiflash] isnull(test.s.b)", + " └─TableFullScan_9 10.00 mpp[tiflash] table:s pushed down filter:eq(test.s.a, 10), keep order:false, stats:pseudo" + ], + "Warn": null } ] }, diff --git a/planner/core/stats.go b/planner/core/stats.go index f8298b15a256e..8831cfa3156db 100644 --- a/planner/core/stats.go +++ b/planner/core/stats.go @@ -24,6 +24,7 @@ import ( "github.com/pingcap/errors" "github.com/pingcap/tidb/domain" "github.com/pingcap/tidb/expression" + "github.com/pingcap/tidb/kv" "github.com/pingcap/tidb/parser/model" "github.com/pingcap/tidb/parser/mysql" "github.com/pingcap/tidb/planner/property" @@ -415,8 +416,14 @@ func (ds *DataSource) derivePathStatsAndTryHeuristics() error { selected = uniqueBest } } - // If some path matches a heuristic rule, just remove other possible paths + // heuristic rule pruning other path should consider hint prefer. + // If no hints and some path matches a heuristic rule, just remove other possible paths. if selected != nil { + // if user wanna tiFlash read, while current heuristic choose a TiKV path. so we shouldn't prune other paths. + keep := ds.preferStoreType&preferTiFlash != 0 && selected.StoreType != kv.TiFlash + if keep { + return nil + } ds.possibleAccessPaths[0] = selected ds.possibleAccessPaths = ds.possibleAccessPaths[:1] var tableName string