planner: fix space requirement when binding from history (#41140) (#4…

…1244)

close #41126

infoschema/cluster_tables_test.go

@@ -852,3 +852,31 @@ func TestMDLView(t *testing.T) {
 
  wg.Wait()
 }
+
+func TestCreateBindingForPrepareToken(t *testing.T) {
+ store := testkit.CreateMockStore(t)
+ tk := testkit.NewTestKit(t, store)
+ require.NoError(t, tk.Session().Auth(&auth.UserIdentity{Username: "root", Hostname: "%"}, nil, nil))
+
+ tk.MustExec("use test")
+ tk.MustExec("drop table if exists t")
+ tk.MustExec("create table t(a int, b time, c varchar(5))")
+
+ //some builtin functions listed in https://dev.mysql.com/doc/refman/8.0/en/function-resolution.html
+ cases := []string{
+ "select std(a) from t",
+ "select cast(a as decimal(10, 2)) from t",
+ "select bit_or(a) from t",
+ "select min(a) from t",
+ "select max(a) from t",
+ "select substr(c, 1, 2) from t",
+ }
+
+ for _, sql := range cases {
+ prep := fmt.Sprintf("prepare stmt from '%s'", sql)
+ tk.MustExec(prep)
+ tk.MustExec("execute stmt")
+ planDigest := tk.MustQuery(fmt.Sprintf("select plan_digest from information_schema.statements_summary where query_sample_text = '%s'", sql)).Rows()
+ tk.MustExec(fmt.Sprintf("create binding from history using plan digest '%s'", planDigest[0][0]))
+ }
+}

util/stmtsummary/statement_summary.go

@@ -516,10 +516,12 @@ func getBindableStmtByPlanDigest(ssbd *stmtSummaryByDigest, planDigest string) *
  Collation: ssElement.collation,
  Users: ssElement.authUsers,
  }
- // If it is SQL command prepare / execute, the ssElement.sampleSQL is `execute ...`, we should get the original select query.
+ // If it is SQL command prepare / execute, we should remove the arguments
  // If it is binary protocol prepare / execute, ssbd.normalizedSQL should be same as ssElement.sampleSQL.
  if ssElement.prepared {
- stmt.Query = ssbd.normalizedSQL
+ if idx := strings.LastIndex(stmt.Query, "[arguments:"); idx != -1 {
+ stmt.Query = stmt.Query[:idx]
+ }
  }
  return stmt
  }