Skip to content

Commit

Permalink
Add test
Browse files Browse the repository at this point in the history
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
  • Loading branch information
MyonKeminta committed Feb 8, 2023
1 parent cca563f commit d89652d
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
8 changes: 8 additions & 0 deletions session/bootstrap.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"time"

"github.com/pingcap/errors"
"github.com/pingcap/failpoint"
"github.com/pingcap/tidb/bindinfo"
"github.com/pingcap/tidb/config"
"github.com/pingcap/tidb/domain"
Expand Down Expand Up @@ -2490,6 +2491,13 @@ func doDMLWorks(s Session) {
case variable.TiDBEnableMutationChecker:
vVal = variable.On
}

failpoint.Inject("enableAggressiveLockingOnBootstrap", func() {
if v.Name == variable.TiDBPessimisticTransactionAggressiveLocking {
vVal = variable.On
}
})

// sanitize k and vVal
value := fmt.Sprintf(`("%s", "%s")`, sqlexec.EscapeString(k), sqlexec.EscapeString(vVal))
values = append(values, value)
Expand Down
15 changes: 15 additions & 0 deletions sessiontxn/isolation/repeatable_read_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -700,3 +700,18 @@ func TestRRWaitTSTimeInSlowLog(t *testing.T) {
require.NotEqual(t, waitTS1, waitTS3)
require.NotEqual(t, waitTS2, waitTS3)
}

func TestIssue41194(t *testing.T) {
require.NoError(t, failpoint.Enable("github.com/pingcap/tidb/session/enableAggressiveLockingOnBootstrap", "return"))
defer func() {
require.NoError(t, failpoint.Disable("github.com/pingcap/tidb/session/enableAggressiveLockingOnBootstrap"))
}()

store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)

tk.MustExec("use test")
tk.MustExec("create table t (id int primary key, v int)")
tk.MustExec("insert into t values (1, 1), (2, 2), (3, 3)")
tk.MustExec("analyze table t")
}

0 comments on commit d89652d

Please sign in to comment.