Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: max-memory has been deleted from 5.0.0, should not displayed in config list of tidb log #23366

Open
seiya-annie opened this issue Mar 17, 2021 · 3 comments
Labels
severity/minor sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@seiya-annie
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. install v4.0.11 with max-memory = 0
  2. upgrade to v5.0.0
  3. check config value in tidb log

2. What did you expect to see? (Required)

max-memory can't find in config list

3. What did you see instead (Required)

["loaded config"] [config="{"host":"0.0.0.0","advertise-address":"172.16.5.101","port":4000,"cors":"","store":"tikv","path":"172.16.5.101:2379","socket":"","lease":"45s","run-ddl":true,"split-table":true,"token-limit":1000,"oom-use-tmp-storage":true,"tmp-storage-path":"/tmp/1003_tidb/MC4wLjAuMDo0MDAwLzAuMC4wLjA6MTAwODA=/tmp-storage","oom-action":"log","mem-quota-query":1073741824,"tmp-storage-quota":-1,"enable-streaming":false,"enable-batch-dml":false,"lower-case-table-names":2,"server-version":"","log":{"level":"info","format":"text","disable-timestamp":null,"enable-timestamp":null,"disable-error-stack":null,"enable-error-stack":null,"file":{"filename":"/home/tidb/deploy/tidb-4000/log/tidb.log","max-size":300,"max-days":0,"max-backups":0},"enable-slow-log":true,"slow-query-file":"log/tidb_slow_query.log","slow-threshold":300,"expensive-threshold":10000,"query-log-max-len":4096,"record-plan-in-slow-log":1},"security":{"skip-grant-table":false,"ssl-ca":"","ssl-cert":"","ssl-key":"","require-secure-transport":false,"cluster-ssl-ca":"","cluster-ssl-cert":"","cluster-ssl-key":"","cluster-verify-cn":null,"spilled-file-encryption-method":"plaintext"},"status":{"status-host":"0.0.0.0","metrics-addr":"","status-port":10080,"metrics-interval":15,"report-status":true,"record-db-qps":false},"performance":{"max-procs":0,"max-memory":0,

4. What is your TiDB version? (Required)

v5.0.0-pre

@seiya-annie seiya-annie added type/bug The issue is confirmed as a bug. severity/minor labels Mar 17, 2021
@seiya-annie
Copy link
Author

/info

@ti-srebot
Copy link
Contributor

ti-srebot commented Mar 17, 2021

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

master, v5.0.0-pre

6. Fixed versions

master

@ti-srebot
Copy link
Contributor

( component or sig(label) ) fields are empty.

@ChenPeng2013 ChenPeng2013 added the sig/execution SIG execution label Mar 18, 2021
@jebter jebter added this to the v5.0.0 ga milestone Mar 22, 2021
@zimulala zimulala removed this from the v5.0.0 ga milestone Mar 23, 2021
@wshwsh12 wshwsh12 removed their assignment Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

6 participants