Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set pessimistic-txn.enabled=false in 4.x version, when upgrade to 5.0.0, the txn mode maybe changed #23709

Closed
seiya-annie opened this issue Mar 30, 2021 · 2 comments
Labels
severity/moderate sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@seiya-annie
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. config pessimistic-txn.enabled=false in 4.x version,
  2. upgrade to 5.0.0 version
  3. check default txn mode

2. What did you expect to see? (Required)

current behavior maybe has the risk of incompatible, should record in release notes

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

v5.0.0-nightly

@seiya-annie seiya-annie added type/bug The issue is confirmed as a bug. severity/moderate labels Mar 30, 2021
@jebter jebter added the sig/transaction SIG:Transaction label Jun 22, 2021
@zyguan
Copy link
Contributor

zyguan commented Dec 30, 2021

Since it's a major version upgrade, and we've already announce that the config is replaced by system variable tidb_txn_mode in our release notes. I don't think we need to guarantee that compatibility.

@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

3 participants