Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context (context.Context) for global variable get/set #38378

Closed
Tracked by #38276
YangKeao opened this issue Oct 10, 2022 · 0 comments · Fixed by #38379
Closed
Tracked by #38276

Add context (context.Context) for global variable get/set #38378

YangKeao opened this issue Oct 10, 2022 · 0 comments · Fixed by #38379
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

Enhancement

The hook of set/get global variable doesn't have a context.Context argument. However, it theoretically could have (from the set statement).#38274 will add a set/get hook which reads from the pd, and it requires the hook has an argument context.Context.

Besides the direct set statement, some codes of tidb use the same functions to set/get the variables directly, and they don't have a context.Context in near stacks. So I'll only add context for the set, show, select statement execution, but not for every usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant