Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotFillCache should be true for Cop task from TTL scan workers #43206

Closed
dbsid opened this issue Apr 19, 2023 · 0 comments · Fixed by #43229
Closed

NotFillCache should be true for Cop task from TTL scan workers #43206

dbsid opened this issue Apr 19, 2023 · 0 comments · Fixed by #43229
Assignees
@lcwangchao
Labels
sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.

Comments

@dbsid
Copy link
Contributor

dbsid commented Apr 19, 2023

Enhancement

It looks like TTL scale worker's full table scan COP KV requests contaminate RocksDB block cache. we need to add NotFillCache: true to avoid this situation.

img_v2_84257a28-a2df-4404-a7c6-f8a5382d54dg

img_v2_c6d6ab36-c059-48b8-8e72-bb6014532dcg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcwangchao lcwangchao

Labels
sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ttl: use SQL_NO_CACHE to skip tikv block cache for TTL scan queries lcwangchao/tidb
2 participants
@lcwangchao @dbsid