Data race in TestSetLabelsConcurrentWithGetLabel

[gengliqi]

Bug Report

WARNING: DATA RACE
Write at 0x00c01a99a6d0 by goroutine 15958:
  github.com/pingcap/tidb/server.TestSetLabelsConcurrentWithGetLabel()
      server/http_handler_test.go:1240 +0x2ce
  github.com/pingcap/tidb/sessionctx/variable.(*SysVar).ValidateWithRelaxedValidation()
      sessionctx/variable/variable.go:361 +0x213
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x73c
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1384 +0xb9
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3312 +0x78c
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x6a
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3578 +0x11e
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2156 +0x2fb
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1702 +0x4eb
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1326 +0x143
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3305 +0x72c
  github.com/pingcap/tidb/server.(*basicHTTPHandlerTestSuite).startServer()
      server/http_handler_test.go:448 +0x119
  github.com/pingcap/tidb/server.TestSetLabelsConcurrentWithGetLabel()
      server/http_handler_test.go:1205 +0x117
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47

Previous read at 0x00c01a99a6d0 by goroutine 31090:
  github.com/pingcap/tidb/config.(*Config).GetTiKVConfig()
      config/config.go:317 +0x134
  github.com/pingcap/tidb/server.TestSetLabelsConcurrentWithGetLabel.func2()
      server/http_handler_test.go:1230 +0x32

[gengliqi]

/severity minor

[jebter]

/component test

[jebter]

/component pd