-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete correctness for system variables #7195
Comments
sure! |
#7196 deal with:
|
Is there any other system variables need to add? @spongedu |
@laidahe you can take a look at https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html and #7196 , and find the remaining system variables in |
## What Add restriction for system variable `thread_pool_size`. ## Reference 1. [MySQL global variable: thread_pool_size](https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_version_compile_os) 2. [TiDB guide to cover more restrictions on system variable ](pingcap#7195)
I am going close this issue since we have better handling for this in system variables now. There are still problems such as #28842 -- but we usually fix them as discovered, and for new system variables introduced we review the MinValue/MaxValue closely. |
In #7117 we add a framework to validate input when set system variables, but not all system variables are checked in that pr because there are too much of them. We should complete these checks step by step.
What to do:
ValidateSetSystemVar
insessionctx/variable/varsutil.go
executor/set_test.go
Notes:
ScopeNone
scope need not be checked because they can't be changed dynamically.The text was updated successfully, but these errors were encountered: