test: port lock table ut from mysql #10376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsishandsome
added
component/test
status/WIP
type/new-feature
and removed
type/new-feature
labels
marsishandsome
force-pushed
the
feature/lock-table-ut
branch
2 times, most recently
from
ebfd548
to
5128e52
Compare
|
@razycs520 PTAL |
marsishandsome
force-pushed
the
feature/lock-table-ut
branch
from
5128e52
to
fdf3b06
Compare
|
/run-all-tests |
|
@winkyao PTAL |
|
/run-all-tests |
|
@winkyao PTAL |
Codecov Report
@@ Coverage Diff @@
## master #10376 +/- ##
===========================================
Coverage 81.4098% 81.4098%
===========================================
Files 423 423
Lines 90973 90973
===========================================
Hits 74061 74061
Misses 11606 11606
Partials 5306 5306 |
crazycs520
reviewed
Jul 16, 2019
crazycs520
reviewed
Jul 16, 2019
marsishandsome
force-pushed
the
feature/lock-table-ut
branch
from
d537f89
to
c6a3a1f
Compare
|
@crazycs520 PTAL again |
|
/run-all-tests |
|
@marsishandsome thanks for your contribution, please follow CONTRIBUTING.md to refine the PR title. |
|
@crazycs520 The two |
|
@tangenta PTAL |
tangenta
reviewed
Jul 18, 2019
| // Test: allow read | ||
| tk.MustExec("lock tables t1 write local") | ||
| tk.MustExec("insert into t1 values(NULL)") | ||
| tk2.MustQuery("select count(*) from t1") |
There was a problem hiding this comment.
Do we need to check the result?
There was a problem hiding this comment.
we do not need to check the result (see mysql lock table test).
marsishandsome
changed the title
done |
zz-jason
added
status/LGT2
marsishandsome
added a commit
to marsishandsome/tidb
that referenced
this pull request
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
port some unit test from mysql for lock table (#10343)
What is changed and how it works?
add some unit test
Tests