Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support add datetime with real interval (#10347) #10418

Merged
merged 3 commits into from
May 11, 2019
Merged

Support add datetime with real interval (#10347) #10418

merged 3 commits into from
May 11, 2019

Conversation

erjiaqing
Copy link
Contributor

Cherry pick #10347 to release 2.1

@erjiaqing erjiaqing requested review from qw4990 and alivxxx May 10, 2019 08:20
alivxxx
alivxxx reviewed May 10, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2019
@jackysp
Copy link
Member

jackysp commented May 10, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

jackysp
jackysp reviewed May 10, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes May 11, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 26d05fa into pingcap:release-2.1 May 11, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@alivxxx alivxxx alivxxx left review comments

@zz-jason zz-jason zz-jason approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erjiaqing @jackysp @zz-jason @alivxxx @sre-bot